build: finalize numactl dependency removal #2648
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @rockwotj |
When DPDK's static libraries are built with libnuma support, they create a dependency that must be propagated to our build system. Currently, we link against libnuma via the "Seastar_NUMA" option (enabled by default), but an upcoming change will remove this option. This commit makes the libnuma linkage explicit when building with DPDK to: 1. Properly express the dependency relationship 2. Ensure builds continue to work after the Seastar_NUMA option is removed 3. Fix the dependency chain from libdpdk to libnuma Implementation details: - Reuses the existing libbsd linkage detection mechanism - Switches from using dpdk_PC_LIBRARIES to dpdk_PC_STATIC_LIBRARIES since both "bsd" and "numa" are only listed in the output of `pkgconf --static libdpdk` Signed-off-by: Kefu Chai <[email protected]>
Following 8ab0267, which dropped the build dependency on numactl, this commit removes all remaining references from the build system. This includes cleaning up template files (.pc.in and .cmake.in) that still contained unnecessary numactl references. Changes: - Remove Findnumactl.cmake since it's no longer needed at configuration time - Remove numactl::numactl library linking as we no longer need its headers or libraries - Remove unused Seastar_NUMA CMake option - Remove numactl from SeastarDependencies.cmake This completes the work started in 8ab0267 and ensures Seastar applications no longer pull in numactl's cflags or libraries during the build process. Signed-off-by: Kefu Chai <[email protected]>
tchaikov
force-pushed
the
build-sans-numa
branch
from
5804d79 to
f62d1c7
Compare
|
Oh nice thanks @tchaikov! I thought we couldn't completely drop the dependency due to dpdk, but it seems that was wrong.. Thanks for fixing! |
|
d01796d was the bit I was missing. Anyways, LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following 8ab0267, which dropped the build dependency on numactl, this commit removes all remaining references from the build system. This includes cleaning up template files (.pc.in and .cmake.in) that still contained unnecessary numactl references.
Changes:
This completes the work started in 8ab0267 and ensures Seastar applications no longer pull in numactl's cflags or libraries during the build process.